Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for comparing results with a specific status #75

Merged
merged 2 commits into from
Apr 3, 2024

Conversation

bclement-ocp
Copy link
Contributor

This patch gives the option to compare only sat/unsat results in the compare2 view (the one that allows to select provers from different runs).

This patch gives the option to compare only sat/unsat results in the
compare2 view (the one that allows to select provers from different
runs).
@bclement-ocp
Copy link
Contributor Author

Screenshot:

image

(For the record, there was a hard-coded string in the version of the wrapper tool that generated the "alt-ergo-4.12.2" file, it is actually Z3 4.12.2)

Copy link
Member

@c-cube c-cube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! A nitpick or two but it's a good idea! :)

@@ -35,6 +36,16 @@ let cmp2sql = function

let pp_cmp = Fmt.of_to_string cmp2sql

let status_to_string = function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

status_to_sql maybe?

@@ -35,6 +36,16 @@ let cmp2sql = function

let pp_cmp = Fmt.of_to_string cmp2sql

let status_to_string = function
| `Sat -> {|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the newlines? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, because I copied from cmp2sql above (:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha! 😂 foisted on my own petard

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually now that I think about it I believe I am also the one who wrote cmp2sql 😬

@c-cube c-cube merged commit e58ee3d into sneeuwballen:master Apr 3, 2024
2 checks passed
@c-cube
Copy link
Member

c-cube commented Apr 3, 2024

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants