Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: starknet timelock execution strategy #600

Merged
merged 25 commits into from
Feb 14, 2024
Merged

Conversation

Orland0x
Copy link
Contributor

@Orland0x Orland0x commented Nov 2, 2023

Starknet Timelock Execution Strategy and tests.

@Orland0x Orland0x force-pushed the feat_timelock_execution branch from ab8ac93 to 67a7e08 Compare November 27, 2023 11:58
@Orland0x Orland0x requested a review from pscott November 29, 2023 12:45
@Orland0x Orland0x changed the title feat: timelock execution feat: starknet timelock execution strategy Nov 29, 2023
@Orland0x Orland0x marked this pull request as ready for review November 29, 2023 13:00
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! A couple of comments :)

timelock_delay: u32,
quorum: u256
) {
// Migration to components planned ; disregard the `unsafe` keyword,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

starknet/src/tests/execution_strategies/timelock.cairo Outdated Show resolved Hide resolved
starknet/src/tests/execution_strategies/timelock.cairo Outdated Show resolved Hide resolved
starknet/src/utils/simple_quorum.cairo Show resolved Hide resolved
starknet/src/utils/space_manager.cairo Show resolved Hide resolved
@Orland0x Orland0x force-pushed the feat_timelock_execution branch from ac49fcb to 1931cc2 Compare February 6, 2024 16:52
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Orland0x Orland0x merged commit fe3c99f into develop Feb 14, 2024
2 checks passed
@Orland0x Orland0x deleted the feat_timelock_execution branch February 14, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants