fix: avoid user votes flashing on load #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sekhmet
reviewed
Jul 22, 2024
Sekhmet
reviewed
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When re-loading the connected users' votes again for the same space, the
votesobject will be cleared before the API requeste, then re-populated again with the results.This creates some flashing on the UI, where the state of an item where the user has already voted will flash briefly to "Not voted" state while the API request is fetching.
This PR will clear the local votes object only for guest user, connected user votes will just overwrite the existing one (removed the object concatenation, as we're just loading and saving in the memory votes from a single space)