feat: support EIP-6963 #1126
Draft
feat: support EIP-6963 #1126
+965
−1,722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonustrack
reviewed
Jan 26, 2025
wa0x6e
force-pushed
the
feat-eip-6963-2
branch
2 times, most recently
from
74404ff to
452daa7
Compare
wa0x6e
force-pushed
the
feat-eip-6963-2
branch
from
8d379e7 to
8918f8c
Compare
wa0x6e
force-pushed
the
feat-eip-6963-2
branch
from
3d078d1 to
e40b4c7
Compare
|
Sometime MetaMask and Phantom connectors are displayed twice, this seems to happen when I open duplicate the page in Chrome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/32
This PR refactor the authentication system, by removing the Lock library and implementing the logic directly.
How to test
NOTE
It looks like a big PR if when you're looking at the number of files changed, but most of them are due to type renaming