feat: handle alias redirection

[ChaituVR]

Summary

Closes: https://github.com/snapshot-labs/workflow/issues/369

• Handle alias spaces redirection
• space's /about should redirect to the space overview page to handle v1's URLs

How to test

1. http://localhost:8080/#/s:gal.eth should redirect to http://localhost:8080/#/s:g-dao.eth
2. http://localhost:8080/#/gal.eth should redirect to http://localhost:8080/#/s:g-dao.eth
3. http://localhost:8080/#/safe.eth should redirect to http://localhost:8080/#/s:safe.eth
4. http://localhost:8080/#/s:safe.eth/about should redirect to should redirect to http://localhost:8080/#/s:safe
5. http://localhost:8080/#/safe.eth/about should redirect to should redirect to http://localhost:8080/#/s:safe

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)

• apps/ui/src/helpers/aliases.json: Language not supported

Comments suppressed due to low confidence (1)

apps/ui/src/routes/index.ts:43

• Ensure that the new redirection logic for handling aliases is covered by tests.

if (to.matched[0]?.name === 'space') {

[bonustrack]

Is this needed? This already direct me to space overview: https://snapshot.org/#/fabien.eth/about

[ChaituVR]

This was handled in the previous code (which is changed now to make it more readable)

redirectPath = `/${metadataNetwork}:${domain}`;
if (rest && !/^\/about$/.test(rest)) {
  redirectPath += rest;
}

[bonustrack]

Can't we just replace the domain here and not change the whole logic? There is plenty of case to test if we change the logic.

[ChaituVR]

Here we match only if the space doesn't have s: for example URLs like /safe.eth/settings,

Updated code handles both URLs with s:safe.eth and safe.eth and redirects to new aliased space

[Sekhmet]

I'm a bit afraid of rewriting the logic like this, it might be hard to find out if we are breaking anything.

Do we need to redirect safe.eth to s:safe.eth? Space should have single canonical URL (aside from hardcoded redirects).

[ChaituVR]

Do we need to redirect safe.eth to s:safe.eth

Yes, else all existing URLs will break, users reference these URLs on their forums or blogs or Twitter, etc.

[ChaituVR]

I have tested most of the cases (also mentioned them in the description)

Also, this is not a complete rewrite but adds one more case to handle aliases and moving /about to routes instead of handling it in this function

[Sekhmet]

I'm mostly concerned by whitelist functionality as this code was used for this as well.

[Sekhmet]

Whitelist is broken:

WHITE_WHITE_LABEL_MAPPING='127.0.0.1;balancer.eth yarn dev

It redirects to http://127.0.0.1:8080/#/s:

[ChaituVR]

Whitelist is broken:

WHITE_WHITE_LABEL_MAPPING='127.0.0.1;balancer.eth yarn dev

It redirects to http://127.0.0.1:8080/#/s:

Thanks for catching this, It was not handled in this guard before as well so I missed it. now we ignore this gaurd if it is a whitelabel domain

[Sekhmet]

@wa0x6e would appreciate if you could take a look to see if it doesn't break anything whitelabel related.

[Sekhmet]

tACK

Looks good to me and it seems to work, but not sure if all edge cases for whitelist are handled. Would be good to get approval from @wa0x6e for this.