-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for offchain space creation #1103
Open
wa0x6e
wants to merge
9
commits into
master
Choose a base branch
from
feat-create-offchain-space
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,814
−367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wa0x6e
force-pushed
the
feat-create-offchain-space
branch
8 times, most recently
from
January 20, 2025 19:54
d340d35
to
18d144e
Compare
wa0x6e
force-pushed
the
feat-create-offchain-space
branch
14 times, most recently
from
January 21, 2025 22:35
00fecc8
to
288e85b
Compare
wa0x6e
force-pushed
the
feat-create-offchain-space
branch
from
January 21, 2025 23:00
288e85b
to
b38f393
Compare
@bonustrack This feature can be tester for UI/workflow/UX. Will ask for code review once more polished |
…hot-labs/sx-monorepo into feat-create-offchain-space
wa0x6e
force-pushed
the
feat-create-offchain-space
branch
from
January 22, 2025 19:27
44a3610
to
db2c620
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes: https://github.com/snapshot-labs/workflow/issues/151
This PR adds the ability to create an offchain.
Workflow is stripped down to the basic, so not delegation/reasuries/etc...
NOTE: the process of configuring voteValidation when using the ticker strategy has been hidden, and is set automatically when necessary
Workflow-wise, it should feel natural, so no more details will be given for unbiaised feedback. (see todo below for missing features)
How to test
Start and connect this branch with a local instance of the hub and sequencer with
Order of
VITE_ENABLED_NETWORKS
matter, the first offchain network ID will be used as network for the offchain space creationYou can use impersonator and connect as
0x91FD2c8d24767db4Ece7069AA27832ffaf8590f3
ons-tn
to see all possible ENS names errorsTo-Do
Those extra feature will come in a later PR, as not essential