Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to go back on space creation #1086

Merged
merged 4 commits into from
Jan 8, 2025
Merged

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Jan 7, 2025

Summary

With this change now it's possible to go back to space creation form to make adjustments.

Closes: https://github.com/snapshot-labs/workflow/issues/309

How to test

  1. Go to http://localhost:8080/#/create
  2. Try to create space.
  3. Once on deployment page and you get prompted to confirm transaction in the wallet reject it.
  4. You can click on "Go back" button and modify space.

Screenshots

image

With this change now it's possible to go back to space creation form
to make adjustments.
@Sekhmet Sekhmet requested a review from bonustrack January 7, 2025 15:06
@Sekhmet Sekhmet self-assigned this Jan 7, 2025
@bonustrack
Copy link
Member

What do you think if the button is available all the time on that page (unless space is already created)? I think also the label currently can be confusing, I would just call it "Go back"

@bonustrack
Copy link
Member

Can we remove the button after "Deploying space" step is success?
image

Copy link
Member

@bonustrack bonustrack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Sekhmet Sekhmet merged commit 3154b74 into master Jan 8, 2025
2 checks passed
@Sekhmet Sekhmet deleted the sekhmet/deploy-space-back branch January 8, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants