Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unsupported Gitcoin Passport stamps #1083

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix: remove unsupported Gitcoin Passport stamps #1083

merged 1 commit into from
Jan 6, 2025

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Jan 6, 2025

Summary

Now if unsupported stamp is in the space settings it will be removed from the list (same behavior as on v1).

Closes: https://github.com/snapshot-labs/workflow/issues/349

How to test

  1. Go to http://localhost:8080/#/s:gitcoindao.eth/settings/proposal
  2. You can select some stamps without errors.
  3. Apply changes.
  4. Open gitcoin passport validation again.
  5. What you selected is still there.

@Sekhmet Sekhmet requested review from ChaituVR and bonustrack January 6, 2025 14:21
ChaituVR
ChaituVR approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@Sekhmet Sekhmet merged commit 84b8a55 into master Jan 6, 2025
2 checks passed
@Sekhmet Sekhmet deleted the sekhmet/remove-unsupported-gitcoin-stamps branch January 6, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChaituVR ChaituVR ChaituVR approved these changes

@bonustrack bonustrack Awaiting requested review from bonustrack

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sekhmet @ChaituVR