Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show Verify signature message for offchain votes #1082

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

Sekhmet
Copy link
Member

@Sekhmet Sekhmet commented Jan 6, 2025

Summary

Offchain votes are not on explorers so we update the message to better reflect this link's purpose.

Closes: https://github.com/snapshot-labs/workflow/issues/295

How to test

  1. Go to http://localhost:8080/#/s:kuikuailian.eth/proposal/0xcbc595f8569a6378f899784f7c2c5ff42e56d3183fde27d31002f1f96f86b56c/votes
  2. Click on three dots, you see Verify signature link.

Screenshots

image

Offchain votes are not on explorers so we update the message
to better reflect this link's purpose.
@Sekhmet Sekhmet requested a review from ChaituVR January 6, 2025 13:48
@Sekhmet Sekhmet self-assigned this Jan 6, 2025
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@Sekhmet Sekhmet merged commit addebca into master Jan 6, 2025
2 checks passed
@Sekhmet Sekhmet deleted the sekhmet/votes-signature branch January 6, 2025 15:30
blaisekonya pushed a commit to blaisekonya/sx-monorepo that referenced this pull request Jan 17, 2025
…1082)

Offchain votes are not on explorers so we update the message
to better reflect this link's purpose.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants