fix(ui): use loading props from UiButton for the loading state (#534)

snapshot-labs · Jul 26, 2024 · dd04ddf · dd04ddf
1 parent 84ca1fb
commit dd04ddf
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 12 deletions.
diff --git a/apps/ui/src/components/ButtonFollow.vue b/apps/ui/src/components/ButtonFollow.vue
@@ -32,10 +32,10 @@ const loading = computed(
     :disabled="loading || isSafeWallet"
     class="group"
     :class="{ 'hover:border-skin-danger': spaceFollowed }"
+    :loading="loading"
     @click.prevent="followedSpacesStore.toggleSpaceFollow(spaceIdComposite)"
   >
-    <UiLoading v-if="loading" />
-    <span v-else-if="spaceFollowed" class="inline-block">
+    <span v-if="spaceFollowed" class="inline-block">
       <span class="group-hover:inline hidden text-skin-danger">Unfollow</span>
       <span class="group-hover:hidden">Following</span>
     </span>

diff --git a/apps/ui/src/views/Proposal/Overview.vue b/apps/ui/src/views/Proposal/Overview.vue
@@ -253,14 +253,10 @@ onBeforeUnmount(() => destroyAudio());
             <UiButton
               class="!p-0 border-0 !h-[auto]"
               :disabled="aiSummaryState.loading"
+              :loading="aiSummaryState.loading"
               @click="handleAiSummaryClick"
             >
-              <UiLoading
-                v-if="aiSummaryState.loading"
-                class="inline-block !w-[22px] !h-[22px]"
-              />
               <IH-sparkles
-                v-else
                 class="inline-block w-[22px] h-[22px]"
                 :class="aiSummaryOpen ? 'text-skin-link' : 'text-skin-text'"
               />
@@ -277,14 +273,12 @@ onBeforeUnmount(() => destroyAudio());
             <UiButton
               class="!p-0 border-0 !h-[auto]"
               :disabled="aiSpeechState.loading"
+              :loading="aiSpeechState.loading"
               @click="handleAiSpeechClick"
             >
-              <UiLoading
-                v-if="aiSpeechState.loading"
-                class="inline-block !w-[22px] !h-[22px]"
-              />
+              <UiLoading class="inline-block !w-[22px] !h-[22px]" />
               <IH-pause
-                v-else-if="audioState === 'playing'"
+                v-if="audioState === 'playing'"
                 class="inline-block w-[22px] h-[22px] text-skin-link"
               />
               <IH-play