Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: Potential Reentrancy in executeQueuedProposal Method #215

Merged
merged 2 commits into from
Jun 20, 2023
Merged

audit: Potential Reentrancy in executeQueuedProposal Method #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be95255
chore: comment explaining possible reentrancy
Jun 20, 2023
727d215
:chore: reentrancy example
Jun 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/execution-strategies/CompTimelockCompatibleExecutionStrategy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,10 @@ contract CompTimelockCompatibleExecutionStrategy is SimpleQuorumExecutionStrateg

/// @notice Executes a queued proposal.
/// @param payload The encoded payload of the proposal to execute.
/// @dev Due to possible reentrancy, one cannot rely on the invariant that proposal payloads are executed atomically.
/// As follows: If Proposal A is composed of MetaTransaction a1 and a2, and proposal B of MetaTransaction b1.
/// If A.a1 executes code that triggers a proposal execution, then the execution order overall can potentially
/// become [A.a1, B.b1, A.a2].
function executeQueuedProposal(bytes memory payload) external {
bytes32 executionPayloadHash = keccak256(payload);

Expand Down
4 changes: 4 additions & 0 deletions src/execution-strategies/TimelockExecutionStrategy.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,10 @@ contract TimelockExecutionStrategy is SimpleQuorumExecutionStrategy, IERC1155Rec

/// @notice Executes a queued proposal.
/// @param payload The proposal execution payload.
/// @dev Due to possible reentrancy, one cannot rely on the invariant that proposal payloads are executed atomically.
/// As follows: If Proposal A is composed of MetaTransaction a1 and a2, and proposal B of MetaTransaction b1.
/// If A.a1 executes code that triggers a proposal execution, then the execution order overall can potentially
/// become [A.a1, B.b1, A.a2].
function executeQueuedProposal(bytes memory payload) external {
bytes32 executionPayloadHash = keccak256(payload);

Expand Down