audit: Space Relies Heavily on Execution Strategy for Correctness #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #214 +/- ##
==========================================
- Coverage 81.11% 80.60% -0.52%
==========================================
Files 28 28
Lines 466 464 -2
Branches 112 110 -2
==========================================
- Hits 378 374 -4
- Misses 73 74 +1
- Partials 15 16 +1
|
pscott
approved these changes
Jun 20, 2023
Comment on lines
-279
to
-282
|
|
||
| // We cache the proposal because we will modify the *real* proposal's finalizationStatus before | ||
| // calling the `execute` function. We will use the `cachedProposal` as an argument to the `execute` function. | ||
| // This allows us to follow the CEI pattern to avoid reentrancy issues. |
There was a problem hiding this comment.
me iz sad, you're the one that mentioned adding a comment here lmao
There was a problem hiding this comment.
i just moved it haha and changed context. since we added some more checks it made sense to explain why we update the finalization status instead of why we cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #171