Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opti equality with FALSE rather than TRUE #225

Merged
merged 4 commits into from
Jun 27, 2023
Merged

Conversation

pscott
Copy link
Collaborator

@pscott pscott commented Jun 27, 2023

snapshots are up because I don't think I've updated my forge-std / OZ / gas-snapshots dependencies, but I manually tested the diff between each commit and it's up only (or rather, down only)

Closes #219

@pscott pscott requested a review from Orland0x June 27, 2023 10:08
@pscott pscott changed the title Opti equality with true Opti equality with FALSE rather than TRUE Jun 27, 2023
@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@9f5f1fe). Click here to learn what that means.
The diff coverage is 75.00%.

@@           Coverage Diff           @@
##             main     #225   +/-   ##
=======================================
  Coverage        ?   80.64%           
=======================================
  Files           ?       28           
  Lines           ?      465           
  Branches        ?      111           
=======================================
  Hits            ?      375           
  Misses          ?       74           
  Partials        ?       16           
Impacted Files Coverage Δ
src/utils/SignatureVerifier.sol 93.33% <50.00%> (ø)
src/Space.sol 96.29% <100.00%> (ø)
src/utils/SpaceManager.sol 77.77% <100.00%> (ø)

Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Orland0x Orland0x merged commit b063080 into main Jun 27, 2023
@Orland0x Orland0x deleted the opti_equality_with_true branch October 11, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gas savings with bool mapping
2 participants