Opti equality with FALSE rather than TRUE (#225)

* chore: initial snapshots * opti: use == FALSE for onlyAuthenticator * opti: use inequality with FALSE rather than true in signature verifier * opti: use false inequality in SpaceManager.sol
snapshot-labs · Jun 27, 2023 · b063080 · b063080
1 parent 3bc77f3
commit b063080
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 10 deletions.
diff --git a/.forge-snapshots/ProposeSigComp.snap b/.forge-snapshots/ProposeSigComp.snap
@@ -1 +1 @@
-148834
+148832
diff --git a/.forge-snapshots/VoteSigComp.snap b/.forge-snapshots/VoteSigComp.snap
@@ -1 +1 @@
-50277
+50313
diff --git a/.forge-snapshots/VoteSigCompMetadata.snap b/.forge-snapshots/VoteSigCompMetadata.snap
@@ -1 +1 @@
-51827
+51856
diff --git a/.forge-snapshots/VoteTxComp.snap b/.forge-snapshots/VoteTxComp.snap
@@ -1 +1 @@
-43824
+43883
diff --git a/.forge-snapshots/VoteTxCompMetadata.snap b/.forge-snapshots/VoteTxCompMetadata.snap
@@ -1 +1 @@
-45415
+45467
diff --git a/src/Space.sol b/src/Space.sol
@@ -170,7 +170,7 @@ contract Space is ISpace, Initializable, IERC4824, UUPSUpgradeable, OwnableUpgra
 
     /// @dev Gates access to whitelisted authenticators only.
     modifier onlyAuthenticator() {
-        if (authenticators[msg.sender] != TRUE) revert AuthenticatorNotWhitelisted();
+        if (authenticators[msg.sender] == FALSE) revert AuthenticatorNotWhitelisted();
         _;
     }
 
@@ -252,7 +252,7 @@ contract Space is ISpace, Initializable, IERC4824, UUPSUpgradeable, OwnableUpgra
         if (block.number >= proposal.maxEndBlockNumber) revert VotingPeriodHasEnded();
         if (block.number < proposal.startBlockNumber) revert VotingPeriodHasNotStarted();
         if (proposal.finalizationStatus != FinalizationStatus.Pending) revert ProposalFinalized();
-        if (voteRegistry[proposalId][voter] == TRUE) revert UserAlreadyVoted();
+        if (voteRegistry[proposalId][voter] != FALSE) revert UserAlreadyVoted();
 
         voteRegistry[proposalId][voter] = TRUE;
 

diff --git a/src/utils/SignatureVerifier.sol b/src/utils/SignatureVerifier.sol
@@ -55,7 +55,7 @@ abstract contract SignatureVerifier is EIP712 {
             bytes memory userProposalValidationParams
         ) = abi.decode(data, (address, string, Strategy, bytes));
 
-        if (usedSalts[author][salt] == TRUE) revert SaltAlreadyUsed();
+        if (usedSalts[author][salt] != FALSE) revert SaltAlreadyUsed();
 
         address recoveredAddress = ECDSA.recover(
             _hashTypedDataV4(
@@ -129,7 +129,7 @@ abstract contract SignatureVerifier is EIP712 {
             (address, uint256, Strategy, string)
         );
 
-        if (usedSalts[author][salt] == TRUE) revert SaltAlreadyUsed();
+        if (usedSalts[author][salt] != FALSE) revert SaltAlreadyUsed();
 
         address recoveredAddress = ECDSA.recover(
             _hashTypedDataV4(

diff --git a/src/utils/SpaceManager.sol b/src/utils/SpaceManager.sol
@@ -31,7 +31,7 @@ contract SpaceManager is OwnableUpgradeable {
     /// @notice Enable a space.
     /// @param space Address of the space.
     function enableSpace(address space) external onlyOwner {
-        if (space == address(0) || (spaces[space] == TRUE)) revert InvalidSpace();
+        if (space == address(0) || (spaces[space] != FALSE)) revert InvalidSpace();
         spaces[space] = TRUE;
         emit SpaceEnabled(space);
     }