audit: prevent reentrancy issues in execute function #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Orland0x
reviewed
Jun 16, 2023
Orland0x
reviewed
Jun 16, 2023
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 82.05% 81.70% -0.35%
==========================================
Files 29 29
Lines 468 470 +2
Branches 114 114
==========================================
Hits 384 384
- Misses 70 73 +3
+ Partials 14 13 -1
|
added 2 commits
June 19, 2023 11:43
pscott
added a commit
that referenced
this pull request
Jun 19, 2023
* audit: prevent reentrancy issues in execute function * comment: add comment for cached proposal * comment: remove comment for finalization status modification * chore: CEI explanation * chore: typo --------- Co-authored-by: Orlando <[email protected]>
Orland0x
added a commit
that referenced
this pull request
Jun 19, 2023
* audit: use uint256 instead of bool in mappings * opti: use uint256 instead of bools in other mappings * chore: define TRUE, FALSE in types * refactor: use TRUE, FALSE consts from types.sol * chore: comment explain pupose of boolean aliases * audit: prevent reentrancy issues in execute function (#207) * audit: prevent reentrancy issues in execute function * comment: add comment for cached proposal * comment: remove comment for finalization status modification * chore: CEI explanation * chore: typo --------- Co-authored-by: Orlando <[email protected]> * refactor: use block numbers to track time (#210) * refactor: timestamps to numbers in space * refactor: block numbers in proposal status funcs * refactored: removed timestamp resolver * refactor: proposal validation to use block nubmers * refactor: removed snapshot block number * chore: updated tests * refactor: make getVotingPower a view function * refactor: revert active proposal limiter to timestamps * refactor: revert timelocks to timestamps * chore: fixed tests * Update IVotingStrategy.sol chore: natspec typo --------- Co-authored-by: Orlando <[email protected]> --------- Co-authored-by: Orlando <[email protected]> Co-authored-by: Orland0x <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #192