Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: erc165 compliancy #209

Merged
merged 1 commit into from
Jun 16, 2023
Merged

audit: erc165 compliancy #209

merged 1 commit into from
Jun 16, 2023

Conversation

pscott
Copy link
Collaborator

@pscott pscott commented Jun 16, 2023

Closes #189

@pscott pscott requested a review from Orland0x June 16, 2023 11:03
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #209 (c187370) into main (b7ff1ef) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #209      +/-   ##
==========================================
+ Coverage   82.05%   82.08%   +0.03%     
==========================================
  Files          29       29              
  Lines         468      469       +1     
  Branches      114      114              
==========================================
+ Hits          384      385       +1     
  Misses         70       70              
  Partials       14       14              
Impacted Files Coverage Δ
...execution-strategies/TimelockExecutionStrategy.sol 79.54% <100.00%> (+0.47%) ⬆️

Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@Orland0x Orland0x merged commit 9bdf448 into main Jun 16, 2023
@Orland0x Orland0x deleted the audit_erc165_compliancy branch October 11, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit: TimelockExecutionStrategy Not Fully ERC165 Compliant
2 participants