audit: erc165 compliancy (#209)

snapshot-labs · Jun 16, 2023 · 9bdf448 · 9bdf448
1 parent b7ff1ef
commit 9bdf448
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/src/execution-strategies/TimelockExecutionStrategy.sol b/src/execution-strategies/TimelockExecutionStrategy.sol
@@ -8,6 +8,7 @@ import { MetaTransaction, Proposal, ProposalStatus } from "../types.sol";
 import { Enum } from "@gnosis.pm/safe-contracts/contracts/common/Enum.sol";
 import { IERC1155Receiver } from "@openzeppelin/contracts/interfaces/IERC1155Receiver.sol";
 import { IERC721Receiver } from "@openzeppelin/contracts/interfaces/IERC721Receiver.sol";
+import { IERC165 } from "@openzeppelin/contracts/interfaces/IERC165.sol";
 
 /// @title Timelock Execution Strategy
 /// @notice Used to execute proposal transactions according to a timelock delay.
@@ -216,6 +217,9 @@ contract TimelockExecutionStrategy is SimpleQuorumExecutionStrategy, IERC1155Rec
 
     /// @notice IERC165 interface support
     function supportsInterface(bytes4 interfaceId) external pure returns (bool) {
-        return interfaceId == type(IERC721Receiver).interfaceId || interfaceId == type(IERC1155Receiver).interfaceId;
+        return
+            interfaceId == type(IERC721Receiver).interfaceId ||
+            interfaceId == type(IERC1155Receiver).interfaceId ||
+            interfaceId == type(IERC165).interfaceId;
     }
 }
diff --git a/test/TimelockExecutionStrategy.t.sol b/test/TimelockExecutionStrategy.t.sol
@@ -11,6 +11,7 @@ import { TestERC1155 } from "./mocks/TestERC1155.sol";
 import { TestERC721 } from "./mocks/TestERC721.sol";
 import { IERC1155Receiver } from "@openzeppelin/contracts/interfaces/IERC1155Receiver.sol";
 import { IERC721Receiver } from "@openzeppelin/contracts/interfaces/IERC721Receiver.sol";
+import { IERC165 } from "@openzeppelin/contracts/interfaces/IERC165.sol";
 
 abstract contract TimelockExecutionStrategyTest is SpaceTest {
     error InvalidSpace();
@@ -476,6 +477,7 @@ abstract contract TimelockExecutionStrategyTest is SpaceTest {
     function testCheckViewFunctions() public {
         assertTrue(timelockExecutionStrategy.supportsInterface(type(IERC721Receiver).interfaceId));
         assertTrue(timelockExecutionStrategy.supportsInterface(type(IERC1155Receiver).interfaceId));
+        assertTrue(timelockExecutionStrategy.supportsInterface(type(IERC165).interfaceId));
         assertEq(timelockExecutionStrategy.getStrategyType(), "SimpleQuorumTimelock");
     }