Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: Potential Reentrancy in executeQueuedProposal Method #215

Merged
merged 2 commits into from
Jun 20, 2023
Merged

audit: Potential Reentrancy in executeQueuedProposal Method #215

merged 2 commits into from
Jun 20, 2023

Conversation

Orland0x
Copy link
Contributor

closes #185

@codecov
Copy link

codecov bot commented Jun 20, 2023 •
edited
Loading

Codecov Report

Merging #215 (727d215) into main (39fb3a0) will decrease coverage by 0.52%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
- Coverage   81.11%   80.60%   -0.52%     
==========================================
  Files          28       28              
  Lines         466      464       -2     
  Branches      112      110       -2     
==========================================
- Hits          378      374       -4     
- Misses         73       74       +1     
- Partials       15       16       +1
Impacted Files Coverage Δ
...tegies/CompTimelockCompatibleExecutionStrategy.sol 82.35% <100.00%> (-0.34%) ⬇️
...execution-strategies/TimelockExecutionStrategy.sol 80.00% <100.00%> (-0.44%) ⬇️

... and 4 files with indirect coverage changes

@Orland0x Orland0x requested a review from pscott June 20, 2023 14:21
pscott
pscott approved these changes Jun 20, 2023
View reviewed changes
Copy link
Collaborator

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@Orland0x Orland0x merged commit 56409d5 into main Jun 20, 2023
@Orland0x Orland0x deleted the audit_execute_queued_reentrancy branch October 11, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pscott pscott pscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

audit: Potential Reentrancy in executeQueuedProposal Method
2 participants
@Orland0x @pscott