Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit: fix reentrancy in vote function #211

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

pscott
Copy link
Collaborator

@pscott pscott commented Jun 16, 2023

Closes #183

@pscott pscott requested a review from Orland0x June 16, 2023 11:25
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #211 (a6c7b08) into main (b7ff1ef) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #211   +/-   ##
=======================================
  Coverage   82.05%   82.05%           
=======================================
  Files          29       29           
  Lines         468      468           
  Branches      114      114           
=======================================
  Hits          384      384           
  Misses         70       70           
  Partials       14       14           
Impacted Files Coverage Δ
src/Space.sol 96.21% <100.00%> (ø)

Copy link
Contributor

@Orland0x Orland0x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uTACK

@Orland0x Orland0x merged commit 2c5b49f into main Jun 16, 2023
@Orland0x Orland0x deleted the audit_reentrancy_in_vote_function branch June 16, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

audit: Multiple Voting if Voting Strategy Calls Untrusted Code
2 participants