audit: fix reentrancy in vote function (#211)

snapshot-labs · Jun 16, 2023 · 2c5b49f · 2c5b49f
1 parent edb987f
commit 2c5b49f
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/.forge-snapshots/VoteSigComp.snap b/.forge-snapshots/VoteSigComp.snap
@@ -1 +1 @@
-50709
+50700
diff --git a/.forge-snapshots/VoteSigCompMetadata.snap b/.forge-snapshots/VoteSigCompMetadata.snap
@@ -1 +1 @@
-52252
+52243
diff --git a/.forge-snapshots/VoteTxComp.snap b/.forge-snapshots/VoteTxComp.snap
@@ -1 +1 @@
-44279
+44270
diff --git a/.forge-snapshots/VoteTxCompMetadata.snap b/.forge-snapshots/VoteTxCompMetadata.snap
@@ -1 +1 @@
-45863
+45854
diff --git a/src/Space.sol b/src/Space.sol
@@ -255,6 +255,8 @@ contract Space is ISpace, Initializable, IERC4824, UUPSUpgradeable, OwnableUpgra
         if (proposal.finalizationStatus != FinalizationStatus.Pending) revert ProposalFinalized();
         if (voteRegistry[proposalId][voter]) revert UserAlreadyVoted();
 
+        voteRegistry[proposalId][voter] = true;
+
         uint256 votingPower = _getCumulativePower(
             voter,
             proposal.snapshotTimestamp,
@@ -263,7 +265,6 @@ contract Space is ISpace, Initializable, IERC4824, UUPSUpgradeable, OwnableUpgra
         );
         if (votingPower == 0) revert UserHasNoVotingPower();
         votePower[proposalId][choice] += votingPower;
-        voteRegistry[proposalId][voter] = true;
 
         if (bytes(metadataURI).length == 0) {
             emit VoteCast(proposalId, voter, choice, votingPower);