audit: Function Visibility Can Be Restricted (#198)

* fix: space initializer visibility * fix: enableSpace, disableSpace, isSpaceEnabled visibility on SpaceManager --------- Co-authored-by: Orlando <[email protected]>
snapshot-labs · Jun 13, 2023 · 4ce13e5 · 4ce13e5
1 parent 9ce547c
commit 4ce13e5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/Space.sol b/src/Space.sol
@@ -82,7 +82,7 @@ contract Space is ISpace, Initializable, IERC4824, UUPSUpgradeable, OwnableUpgra
         Strategy[] memory _votingStrategies,
         string[] memory _votingStrategyMetadataURIs,
         address[] memory _authenticators
-    ) public override initializer {
+    ) external override initializer {
         if (_votingStrategies.length == 0) revert EmptyArray();
         if (_authenticators.length == 0) revert EmptyArray();
         if (_votingStrategies.length != _votingStrategyMetadataURIs.length) revert ArrayLengthMismatch();

diff --git a/src/utils/SpaceManager.sol b/src/utils/SpaceManager.sol
@@ -29,15 +29,15 @@ contract SpaceManager is OwnableUpgradeable {
 
     /// @notice Enable a space.
     /// @param space Address of the space.
-    function enableSpace(address space) public onlyOwner {
-        if (space == address(0) || isSpaceEnabled(space)) revert InvalidSpace();
+    function enableSpace(address space) external onlyOwner {
+        if (space == address(0) || spaces[space]) revert InvalidSpace();
         spaces[space] = true;
         emit SpaceEnabled(space);
     }
 
     /// @notice Disable a space.
     /// @param space Address of the space.
-    function disableSpace(address space) public onlyOwner {
+    function disableSpace(address space) external onlyOwner {
         if (!spaces[space]) revert InvalidSpace();
         spaces[space] = false;
         emit SpaceDisabled(space);
@@ -46,12 +46,12 @@ contract SpaceManager is OwnableUpgradeable {
     /// @notice Check if a space is enabled.
     /// @param space Address of the space.
     /// @return bool whether the space is enabled.
-    function isSpaceEnabled(address space) public view returns (bool) {
+    function isSpaceEnabled(address space) external view returns (bool) {
         return spaces[space];
     }
 
     modifier onlySpace() {
-        if (!isSpaceEnabled(msg.sender)) revert InvalidSpace();
+        if (!spaces[msg.sender]) revert InvalidSpace();
         _;
     }
 }