Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip logging graphQl Errors #728

Merged
merged 3 commits into from
Oct 26, 2023
Merged

fix: skip logging graphQl Errors #728

merged 3 commits into from
Oct 26, 2023

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 25, 2023

Fix #727
Fix SNAPSHOT-HUB-19

Stop logging graphql syntax errors from the metrics middleware

@wa0x6e wa0x6e requested a review from ChaituVR October 25, 2023 11:15
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6b79c3c) 2.43% compared to head (08f2902) 2.43%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #728      +/-   ##
=========================================
- Coverage    2.43%   2.43%   -0.01%     
=========================================
  Files          39      39              
  Lines        2014    2016       +2     
  Branches       37      37              
=========================================
  Hits           49      49              
- Misses       1928    1930       +2     
  Partials       37      37              
Files Coverage Δ
src/helpers/metrics.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 8a7854c into master Oct 26, 2023
4 checks passed
@wa0x6e wa0x6e deleted the fix-727 branch October 26, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GraphQLError: Syntax Error: Expected Name, found "}".
2 participants