Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix space query unable to get past 30k spaces #726

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Conversation

wa0x6e
Copy link
Contributor

@wa0x6e wa0x6e commented Oct 19, 2023

Fix #714

We're limiting the space to 30k, which is a hard limit, since the Space query does not provided any filters to paginate.

This PR adds a created filter in where, to enable paginating the Space object, like the Vote object.

This enable query like

query Spaces {
  spaces(first: 10, skip: 5, where: {created_gt: 1697661410}) {
    name
    created
  }
}

@wa0x6e wa0x6e requested a review from ChaituVR October 19, 2023 05:02
src/graphql/schema.gql Outdated Show resolved Hide resolved
@wa0x6e wa0x6e requested a review from ChaituVR October 27, 2023 06:21
@codecov
Copy link

codecov bot commented Oct 28, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e879301) 2.40% compared to head (3fd4e1b) 2.40%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #726   +/-   ##
======================================
  Coverage    2.40%   2.40%           
======================================
  Files          39      39           
  Lines        2037    2037           
  Branches       37      37           
======================================
  Hits           49      49           
  Misses       1951    1951           
  Partials       37      37           
Files Coverage Δ
src/graphql/helpers.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ChaituVR
ChaituVR previously approved these changes Oct 29, 2023
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

src/graphql/schema.gql Outdated Show resolved Hide resolved
Copy link
Member

@ChaituVR ChaituVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utAck

@wa0x6e wa0x6e merged commit 2d4c97e into master Nov 6, 2023
4 checks passed
@wa0x6e wa0x6e deleted the fix-714 branch November 6, 2023 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get spaces after 30k
2 participants