-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix space query unable to get past 30k spaces #726
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #726 +/- ##
======================================
Coverage 2.40% 2.40%
======================================
Files 39 39
Lines 2037 2037
Branches 37 37
======================================
Hits 49 49
Misses 1951 1951
Partials 37 37
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utAck
Fix #714
We're limiting the space to 30k, which is a hard limit, since the Space query does not provided any filters to paginate.
This PR adds a
created
filter in where, to enable paginating the Space object, like the Vote object.This enable query like