Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: extract cache logic from getVp #938

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Merge branch 'master' into extract-cache

037eca7
Select commit
Loading
Failed to load commit list.
Open

refactor: extract cache logic from getVp #938

Merge branch 'master' into extract-cache
037eca7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 28, 2023 in 1s

75.97% (+3.64%) compared to ddec4db

View this Pull Request on Codecov

75.97% (+3.64%) compared to ddec4db

Details

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (ddec4db) 72.33% compared to head (037eca7) 75.97%.

Files Patch % Lines
src/redis.ts 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
+ Coverage   72.33%   75.97%   +3.64%     
==========================================
  Files          13       14       +1     
  Lines         665      691      +26     
  Branches      106      116      +10     
==========================================
+ Hits          481      525      +44     
+ Misses        180      163      -17     
+ Partials        4        3       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.