Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InsecureRequestWarning from urllib3 #36

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

phmoferring
Copy link

@phmoferring phmoferring commented Oct 15, 2024

Removes the verify=False parameter when creating the s3 resource. Addresses #21

Summary by CodeRabbit

  • New Features

    • Introduced a new configuration class for S3 storage settings, enhancing user customization options.
    • Added optional fields for endpoint_url, access_key, secret_key, token, signature_version, and retries to improve integration with S3 services.
  • Bug Fixes

    • Improved initialization of S3 resources to ensure smoother operation with the new settings.

@phmoferring phmoferring changed the title Fix InsecureRequestWarning from urllib3 fix: InsecureRequestWarning from urllib3 Oct 15, 2024
Copy link

coderabbitai bot commented Oct 15, 2024

Walkthrough

The changes introduce a new data class, StorageProviderSettings, which extends StorageProviderSettingsBase in the snakemake_storage_plugin_s3 module. This class includes optional configuration fields for an S3 storage plugin, such as endpoint_url, access_key, secret_key, token, signature_version, and retries. The StorageProvider class is updated to utilize these settings during initialization of an S3 resource. The existing StorageObject class remains unchanged, preserving its methods for S3 interactions.

Changes

File Path Change Summary
snakemake_storage_plugin_s3/init.py Added StorageProviderSettings class with fields: endpoint_url, access_key, secret_key, token, signature_version, and retries. Modified StorageProvider to use these settings in __post_init__. No significant changes to StorageObject.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant StorageProvider
    participant S3Resource

    User->>StorageProvider: Initialize with StorageProviderSettings
    StorageProvider->>S3Resource: Create S3 resource with settings
    S3Resource-->>StorageProvider: Resource ready
    StorageProvider-->>User: Initialization complete
Loading

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between bd5ac5d and 55aface.

📒 Files selected for processing (1)
  • snakemake_storage_plugin_s3/init.py (0 hunks)
💤 Files with no reviewable changes (1)
  • snakemake_storage_plugin_s3/init.py

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant