Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing keywords for highlighting #30

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rroutsong
Copy link

A lot of missing keywords for snakemake highlighting. Just added into 0.4.0 token lists.

Addresses some or all of issues #23, #18, #14, #22, #25

@rroutsong rroutsong changed the title Added missing keywords for highlighting Fix: added missing keywords for highlighting Oct 5, 2023
@rroutsong rroutsong changed the title Fix: added missing keywords for highlighting fix added missing keywords for highlighting Oct 5, 2023
@rroutsong rroutsong changed the title fix added missing keywords for highlighting fix Oct 5, 2023
@rroutsong rroutsong changed the title fix fix: added missing keywords for highlighting 5 minutes ago Oct 5, 2023
@rroutsong rroutsong changed the title fix: added missing keywords for highlighting 5 minutes ago fix: added missing keywords for highlighting Oct 6, 2023
@corneliusroemer
Copy link
Contributor

Oh you beat me to it, I opened #31 before seeing this. You're still missing 'retries'

@corneliusroemer
Copy link
Contributor

Easier to review if you just change this one file: https://github.com/snakemake/snakemake-lang-vscode-plugin/pull/24/files

@rroutsong
Copy link
Author

No worries, I am sure I missed a few more too I couldn't find a good extensive list of all keywords and their support or deprecation by version.

@corneliusroemer
Copy link
Contributor

Oh damn, I might be wrong, PR #24 doesn't seem to fix syntax highlighting. Have to dig a bit deeper, but thanks for giving this a go. We should figure out how to test it, that'd be useful!

@rroutsong
Copy link
Author

OK I am not so familiar with VScode extension development, so I might have borked it up. But I made this into a local vsix and distributed it to my group and it worked for our highlighting purposes.

@mbhall88
Copy link
Member

pepfile and pepschema also seem to be missing. Could you also add that to this PR?

@rroutsong
Copy link
Author

pepfile and pepschema also seem to be missing. Could you also add that to this PR?

added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants