Add sticky weather #680
Merged
Add sticky weather #680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: I did not spend that long choosing the colour for the dark theme, you may want to suggest something more appropriate. |
|
Color seems fine to me, thanks! |
|
Great, thanks - it was still a bit of a WIP, with regards to the "last-clicked" - it could be perhaps set when it is changed/on load so it would feel a bit more natural. For instance if you want to lock in none, & it is already on none, it will require three clicks. Or if you want to go back to none after an auto change, just one click will go back and lock it in. It is definitely usable but that's mainly why I left it as a draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replicates the pattern (and code) of sticky move, if a weather has been pinned then the auto set weather function will simply return early.
The addition of sticky/pinned weather has been approved in #348 "Allow for 'pinning' weather".