Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly implement type-boosting items in Generation 3 #588

Closed
wants to merge 3 commits into from

Conversation

vivapuffs
Copy link
Contributor

No description provided.

@vivapuffs
Copy link
Contributor Author

jetou informed me that the problem is actually on the sim's end and not the calc's end, so i'm closing this pr

@vivapuffs vivapuffs closed this Nov 30, 2023
@thejetou
Copy link
Collaborator

thejetou commented Dec 1, 2023

For more information, here's the reason for the discrepancy.

PS is chaining the modifiers (search 'chaining' in DaWoblefet's damage dissertation for an explanation) but this only happens in Generation 5 and up while in Generation 4 and below it's just sequential arithmetic operations.

Reading the Emerald source code it's implemented the same way as in the damage-calc by multiplying with 1.1 essentially.

Thank you for the PR, but this will have to be fixed on the PS side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants