-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to file-per-change changelog #3774
Conversation
This commit addresses #3771 (comment)
This commit addresses #3771 (comment)
This commit addresses #3771 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Look forward to not having to merge from main to fix the CHANGELOG ever again
A new generated diff is ready to view.
A new doc preview is ready to view. |
This commit addresses #3774 (comment)
A new generated diff is ready to view.
A new doc preview is ready to view. |
Just curious, why is the |
Thank you for making this change to the changelogger! |
A new generated diff is ready to view.
A new doc preview is ready to view. |
A new generated diff is ready to view.
A new doc preview is ready to view. |
Not sure if I understand the question? If
As of this PR, while rendering release notes,
This won't change compared to what we've been doing for
Again, this is the same as today, just list multiple issues in |
Motivation and Context
Implements RFC: File-per-change changelog
Description
When this PR is merged to
main
, it will impact developer workflow for creating a changelog entry that goes with a PR.Prior to this, one edited
CHANGELOG.next.toml
to enter a changelog entry, but it often caused merge conflicts among us. With this PR, one creates a.md
file (any filename stem will do) under thesmithy-rs/.changelog
directory. This Markdown file has the YAML front matter, and it can be created manually or via theChangeLogger
CLI (see this commit for more details).Here are the highlights of the code changes:
smithy-rs/.changelog
. This is pretty much what it takes to let thesmithy-rs
release infra switch to the new changelog mode.CHANGELOG.next.toml
. It will complain if the file is present.--source-to-truncate
option for thechangelogger
'srender
is now optional because our internal release infra code no longer needs to specify that option (i.e. there is nothing to truncate there).smithy-rs-tool-common
andchangelogger
have been updated so TOML changelog entries used in tests have been re-written to Markdown changelog entries. We want to avoid giving the false impression that TOML changelog entries are still well-supported.Testing
smithy-rs
dry-run release and confirmed the correctness ofCHANGELOG.md
andSDK_CHANGELOG.next.json
in the release artifactsCHANGELOG.md
was rendered correctly inaws-sdk-rust
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.