Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed decoy order #809

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

Alexander-Sol
Copy link
Contributor

Protein decoys are generated using a parallel foreach loop. Previously, this caused the decoy proteins to be written to a list in a non-reproducible way. The order would change each time the protein database was read in.

Now, the decoys are sorted before they are returned to ensure that the list of Proteins is ordered the same way every time.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.21%. Comparing base (e5cf73e) to head (d6658d0).
Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #809   +/-   ##
=======================================
  Coverage   77.21%   77.21%           
=======================================
  Files         218      218           
  Lines       32964    32966    +2     
  Branches     3413     3413           
=======================================
+ Hits        25453    25455    +2     
  Misses       6944     6944           
  Partials      567      567           
Files with missing lines Coverage Δ
...UsefulProteomicsDatabases/DecoyProteinGenerator.cs 90.48% <100.00%> (+0.04%) ⬆️
---- 🚨 Try these New Features:

@trishorts trishorts merged commit 6411360 into smith-chem-wisc:master Nov 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants