-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get Modifications from Full Sequence #796
Merged
trishorts
merged 10 commits into
smith-chem-wisc:master
from
nbollis:GetModificationMethod
Oct 30, 2024
Merged
Get Modifications from Full Sequence #796
trishorts
merged 10 commits into
smith-chem-wisc:master
from
nbollis:GetModificationMethod
Oct 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithSetMods backing method
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #796 +/- ##
=========================================
Coverage ? 76.62%
=========================================
Files ? 215
Lines ? 32127
Branches ? 3311
=========================================
Hits ? 24617
Misses ? 6949
Partials ? 561
|
…n inner exception.
Alexander-Sol
previously approved these changes
Aug 27, 2024
zhuoxinshi
previously approved these changes
Sep 10, 2024
nbollis
dismissed stale reviews from zhuoxinshi and Alexander-Sol
via
October 17, 2024 17:20
2d491e0
Alexander-Sol
approved these changes
Oct 23, 2024
trishorts
approved these changes
Oct 30, 2024
zhuoxinshi
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added two methods in IBiopolymerWithSetModifications allowing one to get out a list or dictionary of modifications from the full sequence and a dictionary of all known modifications.
One private method from PeptideWithSetMods was deleted as it is now obsolete