Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Modifications from Full Sequence #796

Merged
merged 10 commits into from
Oct 30, 2024

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Aug 26, 2024

Added two methods in IBiopolymerWithSetModifications allowing one to get out a list or dictionary of modifications from the full sequence and a dictionary of all known modifications.

One private method from PeptideWithSetMods was deleted as it is now obsolete

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 98.33333% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (master@cb08d67). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ib/Readers/SearchResults/SpectrumMatchTsvReader.cs 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #796   +/-   ##
=========================================
  Coverage          ?   76.62%           
=========================================
  Files             ?      215           
  Lines             ?    32127           
  Branches          ?     3311           
=========================================
  Hits              ?    24617           
  Misses            ?     6949           
  Partials          ?      561           
Files with missing lines Coverage Δ
mzLib/MzLibUtil/MzLibException.cs 100.00% <ø> (ø)
mzLib/Omics/IBioPolymerWithSetMods.cs 98.68% <100.00%> (ø)
...ib/Proteomics/AminoAcidPolymer/AminoAcidPolymer.cs 97.47% <100.00%> (ø)
...roteolyticDigestion/PeptideWithSetModifications.cs 95.93% <100.00%> (ø)
...ib/Readers/SearchResults/SpectrumMatchTsvReader.cs 95.79% <0.00%> (ø)

Alexander-Sol
Alexander-Sol previously approved these changes Aug 27, 2024
zhuoxinshi
zhuoxinshi previously approved these changes Sep 10, 2024
@nbollis nbollis dismissed stale reviews from zhuoxinshi and Alexander-Sol via 2d491e0 October 17, 2024 17:20
@trishorts trishorts merged commit b055693 into smith-chem-wisc:master Oct 30, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants