Edited the MatchedFramgentIon Equals method #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #751 +/- ##
==========================================
- Coverage 75.05% 75.05% -0.01%
==========================================
Files 189 189
Lines 30227 30235 +8
Branches 3033 3035 +2
==========================================
+ Hits 22687 22693 +6
Misses 7028 7028
- Partials 512 514 +2
|
trishorts
previously approved these changes
Dec 12, 2023
nbollis
previously approved these changes
Dec 12, 2023
trishorts
previously approved these changes
Jan 3, 2024
nbollis
previously approved these changes
Jan 3, 2024
YulingDai
previously approved these changes
Jan 11, 2024
nbollis
dismissed stale reviews from YulingDai, trishorts, and themself
via
5015608
nbollis
approved these changes
Feb 7, 2024
trishorts
approved these changes
Feb 8, 2024
YulingDai
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the MatchedFragmentIon.Equals method used a naive check (==) when comparing mz and intensity of two fragment ions.
This causes issues when comparing ions that are equivalent, but were converted to string and then back to ion objects, because of how double comparison works. For example, comparing ions between an equivalent PSM and PsmFromTsv would show that the ions weren't equal, due to very small differences in the intensity/mz values.