Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate extra tab from chromatographic peak #749

Conversation

trishorts
Copy link
Contributor

in dealing with the extra tab in the flashlfq output smith-chem-wisc/FlashLFQ#134
I solved the peaks problem previously but ignored the peptides and proteins output problem. this pr tests and fixes these last two cases.

MICHAEL SHORTREED and others added 30 commits November 18, 2021 12:30
@trishorts trishorts added the bug label Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #749 (83fc4d3) into master (167fa9b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #749   +/-   ##
=======================================
  Coverage   74.89%   74.90%           
=======================================
  Files         185      185           
  Lines       30072    30072           
  Branches     3006     3006           
=======================================
+ Hits        22521    22524    +3     
+ Misses       7038     7036    -2     
+ Partials      513      512    -1     
Files Coverage Δ
mzLib/FlashLFQ/Peptide.cs 100.00% <100.00%> (ø)
mzLib/FlashLFQ/ProteinGroup.cs 97.33% <100.00%> (ø)

... and 1 file with indirect coverage changes

@Alexander-Sol Alexander-Sol merged commit 79207f3 into smith-chem-wisc:master Dec 12, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants