-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toppic search result reading #735
Toppic search result reading #735
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #735 +/- ##
==========================================
+ Coverage 74.40% 74.68% +0.28%
==========================================
Files 171 173 +2
Lines 28862 29201 +339
Branches 2862 2898 +36
==========================================
+ Hits 21474 21809 +335
- Misses 6902 6903 +1
- Partials 486 489 +3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I had a couple small comments/suggestions on the ToppicPrsm class, but they're minor
Added in ability to read and write Toppic search result files in the following formats
prsm
prsm_single
proteoform
proteoform_single
The single files only have one id per row in the tsv file.
The non-single files will have alternative id's as rows underneath the main ID, similar to our ambiguity.