Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toppic search result reading #735

Merged
merged 14 commits into from
Nov 27, 2023

Conversation

nbollis
Copy link
Member

@nbollis nbollis commented Oct 17, 2023

Added in ability to read and write Toppic search result files in the following formats

prsm
prsm_single
proteoform
proteoform_single

The single files only have one id per row in the tsv file.
The non-single files will have alternative id's as rows underneath the main ID, similar to our ambiguity.

@nbollis nbollis added the WIP label Oct 17, 2023
@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #735 (dda045f) into master (d147f54) will increase coverage by 0.28%.
Report is 1 commits behind head on master.
The diff coverage is 98.82%.

❗ Current head dda045f differs from pull request most recent head e858b2b. Consider uploading reports for the commit e858b2b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #735      +/-   ##
==========================================
+ Coverage   74.40%   74.68%   +0.28%     
==========================================
  Files         171      173       +2     
  Lines       28862    29201     +339     
  Branches     2862     2898      +36     
==========================================
+ Hits        21474    21809     +335     
- Misses       6902     6903       +1     
- Partials      486      489       +3     
Files Coverage Δ
...ernalResults/IndividualResultRecords/ToppicPrsm.cs 100.00% <100.00%> (ø)
mzLib/Readers/Util/Converters.cs 92.85% <100.00%> (+5.35%) ⬆️
mzLib/Readers/Util/SupportedFileTypes.cs 91.83% <100.00%> (+2.64%) ⬆️
...ernalResults/ResultFiles/TopPICSearchResultFile.cs 98.39% <98.39%> (ø)

trishorts
trishorts previously approved these changes Oct 30, 2023
Alexander-Sol
Alexander-Sol previously approved these changes Nov 1, 2023
@nbollis nbollis dismissed stale reviews from Alexander-Sol and trishorts via bba8e7b November 3, 2023 16:04
elaboy
elaboy previously approved these changes Nov 21, 2023
Alexander-Sol
Alexander-Sol previously approved these changes Nov 22, 2023
Copy link
Contributor

@Alexander-Sol Alexander-Sol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had a couple small comments/suggestions on the ToppicPrsm class, but they're minor

@nbollis nbollis dismissed stale reviews from Alexander-Sol and elaboy via 5c3512d November 22, 2023 20:20
@trishorts trishorts merged commit 353ae25 into smith-chem-wisc:master Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants