GetClosestOneBasedSpectrumNumber using Binary Search instead of for loop

[elaboy]

The new method uses the Binary Search algorithm to search the closes spectrum of given retention time instead of a for loop.

[codecov]

Codecov Report

Merging #716 (13d3cd0) into master (26e4eef) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 91.66%.

Additional details and impacted files

@@           Coverage Diff           @@
##           master     #716   +/-   ##
=======================================
  Coverage   75.95%   75.96%           
=======================================
  Files         170      170           
  Lines       28801    28823   +22     
=======================================
+ Hits        21876    21895   +19     
- Misses       6925     6928    +3     

Files Changed	Coverage Δ
mzLib/MassSpectrometry/MsDataScan.cs	86.87% <ø> (ø)
mzLib/MassSpectrometry/MsDataFile.cs	95.23% <86.36%> (-2.64%)	⬇️
mzLib/Readers/Mgf/Mgf.cs	94.81% <100.00%> (+0.31%)	⬆️

[Alexander-Sol]

I left a couple of comments, but I see one major issue: A dictionary isn't an ordered collection, so accessing dictionary members by an index will give wacky results sometimes

[elaboy]

I left a couple of comments, but I see one major issue: A dictionary isn't an ordered collection, so accessing dictionary members by an index will give wacky results sometimes

You are right. I changed it to InmmutableSortedDictionary and it is inside the method now.

This feature was eliminated from the code

[kyp4]

Looks good to me :)