Raw file connection not closing #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #709 +/- ##
==========================================
- Coverage 75.95% 75.94% -0.01%
==========================================
Files 170 171 +1
Lines 28801 28845 +44
==========================================
+ Hits 21876 21907 +31
- Misses 6925 6938 +13
|
trishorts
reviewed
Aug 31, 2023
trishorts
reviewed
Aug 31, 2023
trishorts
reviewed
Aug 31, 2023
trishorts
reviewed
Aug 31, 2023
nbollis
reviewed
Sep 14, 2023
Alexander-Sol
requested changes
Sep 14, 2023
Alexander-Sol
approved these changes
Sep 21, 2023
|
Packed and tested in MetaMorpheus with vignette data. Results were the same for all tasks. |
nbollis
approved these changes
Sep 22, 2023
trishorts
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thermo Raw files were not closing once MM finished tasks., users had to close MM in order to not get the error indicating that the file was still being used. Tackled this issue including any method accessing the file inside a using statement.
Tested reading a file and moving it from the directory. Test is passing after the fix.