Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Send bound to interceptors #532

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

aDogCalledSpot
Copy link
Contributor

Autoderived Send implementations are lost when using trait objects. Missing Send bounds can be an issue in async contexts and there doesn't appear to be a reason not to introduce it within this repo.

@buehler buehler enabled auto-merge (squash) March 11, 2024 08:36
@buehler
Copy link
Collaborator

buehler commented Mar 11, 2024

Hey @aDogCalledSpot

Thank you for the contribution!
Would you be so kind and fix the linting error in the in_memory cache implementation? I know you did not touch it, but I cannot merge it otherwise :-)

auto-merge was automatically disabled March 11, 2024 09:40

Head branch was pushed to by a user without write access

@aDogCalledSpot
Copy link
Contributor Author

Fixed

@buehler buehler enabled auto-merge (squash) March 11, 2024 09:42
@buehler buehler merged commit d797a21 into smartive:main Mar 11, 2024
1 check passed
Copy link

🎉 This PR is included in version 4.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@aDogCalledSpot aDogCalledSpot deleted the send_interceptors branch March 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants