-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SearchKeys
functionality to MacKMS
#552
Conversation
360134c
to
9c3c6e2
Compare
bd63571
to
4baf2ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok, I've added a few questions and a comment to see if it is possible to search keys in the secure enclave. For example, all with the default tag would be mackms:se=true
If `se` is not specified in the search query, all keys managed by the KMS (using the default tag) will be returned. When `se=true`, or `se=false`, keys will be filtered based on whether they were created inside the Secure Enclave or not, respectively.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
In the switch cases, we could remove the se=false in the name URI, which would be the default for individual keys.
In follow up PRs I'd like to add: