Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly set destroyScheduledDuration to 24h #363

Closed
wants to merge 1 commit into from
Closed

Explicitly set destroyScheduledDuration to 24h #363

wants to merge 1 commit into from

Conversation

dopey
Copy link
Contributor

@dopey dopey commented Nov 8, 2023

  • GCP is changing the default value from 24h to 30 days in a few months. This change makes sure that everything remains at the current value.

@dopey
Explicitly set destroyScheduledDuration to 24h
a6ffc70 
- GCP is changing the default value from 24h to 30 days in a few months.
  This change makes sure that everything remains at the current value.
@dopey dopey requested a review from maraino November 8, 2023 05:33
maraino
maraino reviewed Nov 8, 2023
View reviewed changes
Copy link
Contributor

@maraino maraino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is the proper way to do it. We might want make this configurable.

@dopey
Copy link
Contributor Author

dopey commented Nov 8, 2023

100% we want to make this configurable. However, this will at least keep things with the status quo for now. Otherwise it will switch to 30 days and then we'll be paying for destroyed keys even longer.

maraino added a commit that referenced this pull request Nov 28, 2023
@maraino
Add a configurable retention period for cloudkms keys
1c97dd6 
This commit adds a new option RetentionPeriod to the kms.CreateKey
method to define the period which a deleted key is recovarable.
Currently this is only implemented by cloudkms.

Fixes #363
@maraino maraino mentioned this pull request Nov 28, 2023
Merged
@dopey dopey closed this Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maraino maraino maraino left review comments

Assignees

@dopey dopey

Labels
needs triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dopey @maraino