Add pemutil.UnbundleCertificate #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes a certificate from a bundle.
maraino
requested changes
Oct 25, 2023
pemutil/pem.go
Outdated
Comment on lines
769
to
773
| block, err := Serialize(cert) | ||
| if err != nil { | ||
| return nil, false, err | ||
| } | ||
| keep = append(keep, pem.EncodeToMemory(block)...) |
There was a problem hiding this comment.
Simplify these lines with:
Suggested change
| block, err := Serialize(cert) | |
| if err != nil { | |
| return nil, false, err | |
| } | |
| keep = append(keep, pem.EncodeToMemory(block)...) | |
| keep = append(keep, pem.EncodeToMemory(&pem.Block{ | |
| Type: "CERTIFICATE", | |
| Bytes: cert.Raw, | |
| })...) |
pemutil/pem.go
Outdated
| func UnbundleCertificate(bundlePEM []byte, certsPEM ...[]byte) ([]byte, bool, error) { | ||
| drop := make(map[[sha256.Size224]byte]bool, len(certsPEM)) | ||
| for i := range certsPEM { | ||
| cert, err := ParseCertificate(certsPEM[i]) |
There was a problem hiding this comment.
I can see using this function but having certsPEM[i] as a certificate bundle. If a read a bundle and want to remove one cert, I don't want to split the bundle in multiple certs.
|
|
||
| // UnbundleCertificate removes PEM-encoded certificates from a PEM-encoded | ||
| // certificate bundle. | ||
| func UnbundleCertificate(bundlePEM []byte, certsPEM ...[]byte) ([]byte, bool, error) { |
There was a problem hiding this comment.
Optionally, return the original bundle if len(certsPEM) == 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a certificate from a bundle.
Name of feature:
pemutil.UnbundleCertificate.
Pain or issue this feature alleviates:
BundleCertificate lets you create a new bundle with additional certificates but there was no way to remove certificates from a bundle.
Why is this important to the project (if not answered above):
Is there documentation on how to use this feature? If so, where?
In what environments or workflows is this feature supported?
In what environments or workflows is this feature explicitly NOT supported (if any)?
Supporting links/other PRs/issues:
💔Thank you!