Add helpers to return the kms from an uri #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces the helper kms.TypeOf that returns the type of an uri. It also normalizes the type when neceesary.
hslatman
approved these changes
Oct 24, 2023
Comment on lines
+16
to
+21
| registry.Store(t.normalize(), fn) | ||
| } | ||
|
|
||
| // LoadKeyManagerNewFunc returns the function initialize a KayManager. | ||
| func LoadKeyManagerNewFunc(t Type) (KeyManagerNewFunc, bool) { | ||
| v, ok := registry.Load(t) | ||
| v, ok := registry.Load(t.normalize()) |
There was a problem hiding this comment.
Have a slight preference for doing the t.normalize() inside of .Load and .Store instead of the method call here, but not a blocker.
Comment on lines
+165
to
171
| case OpaqueSigner: | ||
| for _, alg := range k.Algs() { | ||
| if jwk.Algorithm == string(alg) { | ||
| return nil | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
I assume the default errctx value is sufficient for this case?
There was a problem hiding this comment.
Yes, that was the idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit introduces the helper
kms.TypeOf, which returns the type of a URI. It also normalizes the type when necessary.It also adds a commit to be able to validate JWKs that use an OpaqueSigner.