Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation of a DPoP proofing mechanism #277
base: main
Are you sure you want to change the base?
Initial implementation of a DPoP proofing mechanism #277
Changes from 1 commit
58c5e85
cb1a8f0
076fe8b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This algorithm is used for decrypting the claims or inner signed tokens when dealing with the access token. I believe you meant
getSignatureAlgorithm
.But you have a good point about
ES256
/etc - I propose that we have a new property added,smallrye.jwt.verify.dpop.signature-algorithm
(and we doc it is for the DPoP proof JWT verification), its default value is the same as that ofsmallrye.jwt.verify.signature-algorithm
which isRS256
but the users can chooseES256
.What do you think ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I did mean
getSignatureAlgorithm
. I like your suggestion for adding asmallrye.jwt.verify.dpop.signature-algorithm
config property