add additional default commands listed in xubuntu's xflock4 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds additional default commands, taken from the xflock4 version shipped by Ubuntu (which contains more command than xfce's version). Additionally, I've added physlock as a last-resort fallback.
In my testing the order seems to be relevant, since XUbuntu 22.04 ships with a xdg-screensaver version that doesn't support the lock option (you get an error message and exit code 4 instead), but it does support xfce4-screensaver-command.
Aside: xflock4 also first tries to find a lock command configured in xfconf, by calling
xfconf-query -c xfce4-session -p /general/LockCommand. That doesn't neatly fit into what this library is doing so far, so I didn't add it here, but I think it's an interesting option to explore.