Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tolerations fix for deployment template #503

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ronballesteros
Copy link

Summary

There is an issue with the current deployment template yaml file when setting tolerations in the values.yaml file.

Setting the tolerations in the values.yaml file:

tolerations:
  - key: "infra"
     operator: "Equal"
     value: "true"
     effect: "NoSchedule"

Error message when deploying:

k apply -f sloth4.yaml -n sloth 
...
serviceaccount/sloth created
clusterrole.rbac.authorization.k8s.io/sloth created
clusterrolebinding.rbac.authorization.k8s.io/sloth created
Error from server (BadRequest): error when creating "sloth4.yaml": Deployment in version "v1" cannot be handled as a Deployment: strict decoding error: unknown field "spec.template.spec.containers[0].tolerations"

Fix

This PR fixes the deployment.yaml issue by moving the tolerations on the pod spec level.

@ronballesteros ronballesteros requested a review from slok as a code owner May 13, 2023 09:14
@sstarcher
Copy link

@slok any chance to get this merged?

@sstarcher sstarcher mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants