Ci upgrades #28
Merged
Ci upgrades #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these are not needed for this proxy version of the project.. yet
previously didn't pass credo checks for cyclomatic complexity separating functionality lowers complexity below acceptable threshold
conditionally show debug logs in production move proxy configs out of emailer config block move functionality for proxy_config from config/config.exs to config/runtime.exs section off proxy_config for prod, dev, default(test) provide more solid default configs for dev/test and fail conditions for unconfigured values in prod don't configure proxy repo in :test env
consolidated into config/runtime proxy :dev section
… test prevent test from trying to run proxy code
don't run proxy by_category if boards seq is lower than 0 (test mode)
push docker image to github container registry
refactor for edge case; code was failing when thread did not exist
akinsey
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run github workflows for static code analysis, testing, image build and push
pushes docker image to this ghcr for this repo upon success
contains refactoring for configs, updates code to pass tests, refactor/style fixes for static code analysis