Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hillslope testing fsurdat to 5.3 #12

Merged

Conversation

samsrabin
Copy link

@samsrabin samsrabin commented Sep 9, 2024

Resolves ESCOMP#2748

  • hillslope test suite, Derecho: Completes successfully
  • rimport
  • hillslope test suite, Izumi: Completes successfully

@samsrabin samsrabin marked this pull request as ready for review September 9, 2024 22:47
@samsrabin
Copy link
Author

@slevis-lmwg This is ready!

Copy link
Owner

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am requesting a change in file path.

@@ -6,6 +6,6 @@ hillslope_transmissivity_method = 'LayerSum'
hillslope_pft_distribution_method = 'PftLowlandUpland'
hillslope_soil_profile_method = 'Uniform'

fsurdat = '$DIN_LOC_ROOT/lnd/clm2/testdata/surfdata_10x15_hist_2000_78pfts_c240216.synthetic_hillslopes.nc'
fsurdat = '$DIN_LOC_ROOT/lnd/clm2/testdata/surfdata_10x15_hist_2000_78pfts_c240905.synthetic_hillslopes3.nc'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @samsrabin!

A correction though:
@ekluzek and I decided to group all synthetic fsurdat/landuse files in .../lnd/clm2/surfdata_esmf/ctsm5.3.0/synthetic

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

...as in ESCOMP#2515

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek please correct me if I misunderstood.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, sorry!

@samsrabin
Copy link
Author

Re-testing...

@samsrabin
Copy link
Author

Done and passed!

Copy link
Owner

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and then merging. Thanks again, @samsrabin.

@slevis-lmwg slevis-lmwg merged commit e5d96a0 into slevis-lmwg:new_rawpftlai Sep 10, 2024
1 check passed
@slevis-lmwg slevis-lmwg deleted the update-hillslope-fsurdat-5.3 branch September 10, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants