Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update surface datasets in namelist defaults #10

Merged

Conversation

ekluzek
Copy link
Collaborator

@ekluzek ekluzek commented Sep 6, 2024

Update names in namelist defaults to new cctsm5.3.0 datasets.

@ekluzek ekluzek added the enhancement New feature or request label Sep 6, 2024
@ekluzek ekluzek self-assigned this Sep 6, 2024
@ekluzek ekluzek changed the title [WIP] Update surface datasets in namelist defaults Update surface datasets in namelist defaults Sep 10, 2024
Copy link
Owner

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, so I'm approving. This PR shows me that I still need to generate a second batch of NEON files.

bld/namelist_files/namelist_defaults_ctsm.xml Outdated Show resolved Hide resolved
Copy link
Owner

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ekluzek I will go ahead and approve. I am ready to start the test-suites as soon as this PR gets merged.

bld/CLMBuildNamelist.pm Outdated Show resolved Hide resolved
cime_config/usermods_dirs/NEON/FATES/defaults/user_nl_clm Outdated Show resolved Hide resolved
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 11, 2024

OK, I've verified the new files are all correctly in place via the build-namelist tester, and I made sure all of the fsurdat files it's using are the new ones and not old ones.

@ekluzek ekluzek merged commit 01476b6 into slevis-lmwg:new_rawpftlai Sep 11, 2024
1 check passed
@ekluzek ekluzek deleted the new_surf_in_namelist_defaults branch September 11, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants