Fix lint warnings

handlers/main.yaml

@@ -1,15 +1,16 @@
 ---
 - name: Reload initd
-  command: initctl reload-configuration
+  ansible.builtin.command: initctl reload-configuration
+  changed_when: false
 
 - name: Restart kafka service
-  service:
+  ansible.builtin.service:
     name: kafka
     state: restarted
   when: kafka_restart
 
 - name: Restart kafka systemd
-  systemd:
+  ansible.builtin.systemd:
     name: kafka
     state: restarted
     daemon_reload: yes

meta/main.yml

@@ -9,9 +9,9 @@ galaxy_info:
   platforms:
     - name: EL
       versions:
-        - 6
-        - 7
-        - 8
+        - '6'
+        - '7'
+        - '8'
     - name: Debian
       versions:
         - buster

molecule/default/converge.yml

@@ -6,5 +6,5 @@
 
   tasks:
     - name: 'Test Kafka role'
-      include_role:
+      ansible.builtin.include_role:
         name: "{{ lookup('env', 'MOLECULE_PROJECT_DIRECTORY') | basename }}"

molecule/default/prepare.yml

@@ -5,13 +5,13 @@
 
   pre_tasks:
     - name: Install Java 8 (OpenJDK) on RedHat/CentOS
-      yum:
+      ansible.builtin.yum:
         name: java-1.8.0-openjdk
         state: installed
       when: ansible_os_family == "RedHat"
 
     - name: Install Java 11 (OpenJDK) on Debian
-      apt:
+      ansible.builtin.apt:
         name: openjdk-11-jdk
         state: present
         update_cache: yes
@@ -23,7 +23,7 @@
     # ZooKeeper service is constantly restarted by systemd which causes
     # the Molecule tests to fail as the service is not started correctly.
     - name: Install ps on Debian
-      apt:
+      ansible.builtin.apt:
         name: procps
         state: present
       when: ansible_os_family == "Debian"

molecule/default/verify.yml

@@ -3,39 +3,39 @@
 
   tasks:
     - name: Get users
-      getent:
+      ansible.builtin.getent:
         database: passwd
 
     - name: Get groups
-      getent:
+      ansible.builtin.getent:
         database: group
 
-    - name: Assert that user and group 'kafka' exists
-      assert:
+    - name: ansible.builtin.assert that user and group 'kafka' exists
+      ansible.builtin.assert:
         that:
           - "'kafka' in getent_passwd"
           - "'kafka' in getent_group"
 
     - name: Register '/opt/kafka_2.13-3.5.1' installation directory status
-      stat:
+      ansible.builtin.stat:
         path: '/opt/kafka_2.13-3.5.1'
       register: install_dir
 
-    - name: Assert that '/opt/kafka_2.13-3.5.1' directory is created
-      assert:
+    - name: ansible.builtin.assert that '/opt/kafka_2.13-3.5.1' directory is created
+      ansible.builtin.assert:
         that:
           - install_dir.stat.exists
           - install_dir.stat.isdir
           - install_dir.stat.pw_name == 'kafka'
           - install_dir.stat.gr_name == 'kafka'
 
     - name: Register '/opt/kafka' symlink directory status
-      stat:
+      ansible.builtin.stat:
         path: '/opt/kafka'
       register: kafka_dir
 
-    - name: Assert that '/opt/kafka' symlink is created
-      assert:
+    - name: ansible.builtin.assert that '/opt/kafka' symlink is created
+      ansible.builtin.assert:
         that:
           - kafka_dir.stat.exists
           - kafka_dir.stat.islnk
@@ -46,21 +46,21 @@
         path: '/var/log/kafka'
       register: kafka_log_dir
 
-    - name: Assert that '/var/log/kafka' directory is created
-      assert:
+    - name: ansible.builtin.assert that '/var/log/kafka' directory is created
+      ansible.builtin.assert:
         that:
           - kafka_log_dir.stat.exists
           - kafka_log_dir.stat.isdir
           - kafka_log_dir.stat.pw_name == 'kafka'
           - kafka_log_dir.stat.gr_name == 'kafka'
 
     - name: Register '/opt/kafka/logs' symlink directory status
-      stat:
+      ansible.builtin.stat:
         path: '/opt/kafka/logs'
       register: application_logs_symlink
 
-    - name: Assert that '/opt/kafka/logs' symlink is created
-      assert:
+    - name: ansible.builtin.assert that '/opt/kafka/logs' symlink is created
+      ansible.builtin.assert:
         that:
           - application_logs_symlink.stat.exists
           - application_logs_symlink.stat.islnk
@@ -69,23 +69,23 @@
           - application_logs_symlink.stat.gr_name == 'kafka'
 
     - name: Register '/etc/kafka' directory status
-      stat:
+      ansible.builtin.stat:
         path: '/etc/kafka'
       register: config_dir
 
-    - name: Assert that '/etc/kafka' directory is created
-      assert:
+    - name: ansible.builtin.assert that '/etc/kafka' directory is created
+      ansible.builtin.assert:
         that:
           - config_dir.stat.exists
           - config_dir.stat.isdir
           - config_dir.stat.pw_name == 'kafka'
           - config_dir.stat.gr_name == 'kafka'
 
     - name: Populate service facts
-      service_facts:
+      ansible.builtin.service_facts:
 
-    - name: Assert that Kafka service is installed, running, and enabled
-      assert:
+    - name: ansible.builtin.assert that Kafka service is installed, running, and enabled
+      ansible.builtin.assert:
         that:
           - "'kafka.service' in ansible_facts.services"
           - ansible_facts.services['kafka.service'].state == 'running'