Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: when decoding CSV, do not include empty fields as nodes #201

Closed
wants to merge 1 commit into from

Conversation

nikaera
Copy link
Contributor

@nikaera nikaera commented Mar 17, 2024

When using CSV for translation files, if specific fields are empty, it can be assumed that the translation is not provided. Therefore, I made modifications to handle such cases accordingly. ✅

@Tienisto
Copy link
Member

Could you please try the fallback_strategy: base_locale_empty_string configuration?
Your change might break others code if they actually expect an empty string.

@nikaera nikaera closed this Mar 17, 2024
@nikaera nikaera deleted the fix/csv-decoder-input branch March 17, 2024 14:10
@nikaera
Copy link
Contributor Author

nikaera commented Mar 17, 2024

Thank you very much for the detailed explanation! Adding fallback_strategy: base_locale_empty_string to build.yaml as you suggested has resulted in the intended behavior! 🙌 @Tienisto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants