-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] #907 #908 #911
base: main
Are you sure you want to change the base?
[Fix] #907 #908 #911
Conversation
chunk_req, | ||
*args | ||
), | ||
max_retries=1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running this with max_retries=1
should make a different from the original code, since it'll just call the function once - are you sure this is what fixed the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the process fails, the sender will put the request chunk back into the cache.
Running this with
max_retries=1
should make a different from the original code, since it'll just call the function once - are you sure this is what fixed the issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but either way I don't think making this changes helps, since either way the function is only called once.
Could you please make sure the formatting checks pass? You can check them with:
|
Hi Sarah, I add try and catch to the receiver and the sender. However, I can't test.
|
Fix bug #907 #908