Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] #907 #908 #911

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

killerdbob
Copy link
Contributor

Fix bug #907 #908

chunk_req,
*args
),
max_retries=1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this with max_retries=1 should make a different from the original code, since it'll just call the function once - are you sure this is what fixed the issue?

Copy link
Contributor Author

@killerdbob killerdbob Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if the process fails, the sender will put the request chunk back into the cache.

Running this with max_retries=1 should make a different from the original code, since it'll just call the function once - are you sure this is what fixed the issue?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but either way I don't think making this changes helps, since either way the function is only called once.

@sarahwooders
Copy link
Contributor

Could you please make sure the formatting checks pass? You can check them with:

poetry run black . --line-length=140 && poetry run pytype . --config .pytype.cfg -j 16

@killerdbob
Copy link
Contributor Author

Hi Sarah, I add try and catch to the receiver and the sender. However, I can't test.

Could you please make sure the formatting checks pass? You can check them with:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants